Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper.virtual.removeSlide has a bug #7020

Closed
5 of 6 tasks
xiayejinchen opened this issue Sep 7, 2023 · 4 comments · May be fixed by abhishekbedi/framework7#1, Aarod23/nys-site#1, wierza/Team-project#148 or TaylorBundy/swiper#4
Closed
5 of 6 tasks

Comments

@xiayejinchen
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

https://github.com/nolimits4web/swiper.git

Bug description

When using swiper.virtual.removeSlide to delete a cached virtual slide, for example, if 4 slides have been cached and slide 2 is deleted, two slides 3 will appear.

Because virtual.cache is an object, just delete key of virtual.cache,for example 2,virtual.cache will be equal to {1:'slide 1', 3: 'slide 3', 4: 'slide 4'}. And After swiper.virtual.update, virtual.cache will be equal to {1:'slide 1', 2:'slide 3', 3: 'slide 3', 4: 'slide 4'}

Expected Behavior

No response

Actual Behavior

No response

Swiper version

8b73864

Platform/Target and Browser Versions

chrome

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Hello @xiayejinchen. Please provide a online reproduction by codesandbox or a minimal GitHub repository. You can fork one of our demos in codesandbox to get start. Issues labeled by missing demo will be closed if no activities in 3 days.

@xiayejinchen
Copy link
Author

you can see the demo in https://github.com/xiayejinchen/test.git

@nolimits4web
Copy link
Owner

nolimits4web commented Sep 8, 2023 via email

@xiayejinchen
Copy link
Author

You can see the demo at https://6lxtmm.csb.app/

After you see the 'slide 4', then delete 'slide 3', you will see two 'slide 4'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment