-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swiper.virtual.removeSlide has a bug #7020
swiper.virtual.removeSlide has a bug #7020
Comments
Hello @xiayejinchen. Please provide a online reproduction by codesandbox or a minimal GitHub repository. You can fork one of our demos in codesandbox to get start. Issues labeled by |
you can see the demo in |
Why not create CodeSandbox?
Kind regards,
Vladimir Kharlampidi
…________________________________
From: xiaobai ***@***.***>
Sent: Friday, September 8, 2023 12:55:41 PM
To: nolimits4web/swiper ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [nolimits4web/swiper] swiper.virtual.removeSlide has a bug (Issue #7020)
you can see the demo in https://github.com/xiayejinchen/test.git
—
Reply to this email directly, view it on GitHub<#7020 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHUBJHZHMBLJ4O4MSRHH43XZLTR3ANCNFSM6AAAAAA4PEXWC4>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
You can see the demo at After you see the 'slide 4', then delete 'slide 3', you will see two 'slide 4' |
Check that this is really a bug
Reproduction link
https://github.com/nolimits4web/swiper.git
Bug description
When using swiper.virtual.removeSlide to delete a cached virtual slide, for example, if 4 slides have been cached and slide 2 is deleted, two slides 3 will appear.
Because virtual.cache is an object, just delete key of virtual.cache,for example 2,virtual.cache will be equal to {1:'slide 1', 3: 'slide 3', 4: 'slide 4'}. And After swiper.virtual.update, virtual.cache will be equal to {1:'slide 1', 2:'slide 3', 3: 'slide 3', 4: 'slide 4'}
Expected Behavior
No response
Actual Behavior
No response
Swiper version
8b73864
Platform/Target and Browser Versions
chrome
Validations
Would you like to open a PR for this bug?
The text was updated successfully, but these errors were encountered: