chore: add getSlideIndexByData method

nolimits4web · Mar 16, 2023 · bcb275f · bcb275f
1 parent e24bd8c
commit bcb275f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 16 deletions.
diff --git a/src/core/core.js b/src/core/core.js
@@ -229,6 +229,14 @@ class Swiper {
     return elementIndex(slideEl) - firstSlideIndex;
   }
 
+  getSlideIndexByData(index) {
+    return this.getSlideIndex(
+      this.slides.filter(
+        (slideEl) => slideEl.getAttribute('data-swiper-slide-index') * 1 === index,
+      )[0],
+    );
+  }
+
   recalcSlides() {
     const swiper = this;
     const { slidesEl, params } = swiper;

diff --git a/src/core/slide/slideToLoop.js b/src/core/slide/slideToLoop.js
@@ -17,11 +17,7 @@ export default function slideToLoop(
       // eslint-disable-next-line
       newIndex = newIndex + swiper.virtual.slidesBefore;
     } else {
-      newIndex = swiper.getSlideIndex(
-        swiper.slides.filter(
-          (slideEl) => slideEl.getAttribute('data-swiper-slide-index') * 1 === newIndex,
-        )[0],
-      );
+      newIndex = swiper.getSlideIndexByData(newIndex);
     }
   }
 

diff --git a/src/core/update/updateAutoHeight.js b/src/core/update/updateAutoHeight.js
@@ -12,9 +12,7 @@ export default function updateAutoHeight(speed) {
 
   const getSlideByIndex = (index) => {
     if (isVirtual) {
-      return swiper.slides.filter(
-        (el) => parseInt(el.getAttribute('data-swiper-slide-index'), 10) === index,
-      )[0];
+      return swiper.getSlideIndexByData(index);
     }
     return swiper.slides[index];
   };

diff --git a/src/core/update/updateProgress.js b/src/core/update/updateProgress.js
@@ -25,14 +25,8 @@ export default function updateProgress(translate) {
   }
 
   if (params.loop) {
-    const firstSlideIndex = swiper.getSlideIndex(
-      swiper.slides.filter((el) => el.getAttribute('data-swiper-slide-index') === '0')[0],
-    );
-    const lastSlideIndex = swiper.getSlideIndex(
-      swiper.slides.filter(
-        (el) => el.getAttribute('data-swiper-slide-index') * 1 === swiper.slides.length - 1,
-      )[0],
-    );
+    const firstSlideIndex = swiper.getSlideIndexByData(0);
+    const lastSlideIndex = swiper.getSlideIndexByData(swiper.slides.length - 1);
     const firstSlideTranslate = swiper.slidesGrid[firstSlideIndex];
     const lastSlideTranslate = swiper.slidesGrid[lastSlideIndex];
     const translateMax = swiper.slidesGrid[swiper.slidesGrid.length - 1];