fix(components): fixed issue with navigation, pagination, scrollbar c…

…ustom elements added after initialization fixes #4458
nolimits4web · Apr 20, 2021 · cfd4efd · cfd4efd
1 parent 097109f
commit cfd4efd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/src/react/update-swiper.js b/src/react/update-swiper.js
@@ -8,6 +8,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
   let needPaginationInit;
   let needScrollbarInit;
   let needNavigationInit;
+
   if (
     changedParams.includes('thumbs') &&
     passedParams.thumbs &&
@@ -30,7 +31,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
     changedParams.includes('pagination') &&
     passedParams.pagination &&
     passedParams.pagination.el &&
-    currentParams.pagination &&
+    (currentParams.pagination || currentParams.pagination === false) &&
     pagination &&
     !pagination.el
   ) {
@@ -41,7 +42,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
     changedParams.includes('scrollbar') &&
     passedParams.scrollbar &&
     passedParams.scrollbar.el &&
-    currentParams.scrollbar &&
+    (currentParams.scrollbar || currentParams.scrollbar === false) &&
     scrollbar &&
     !scrollbar.el
   ) {
@@ -53,7 +54,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
     passedParams.navigation &&
     passedParams.navigation.prevEl &&
     passedParams.navigation.nextEl &&
-    currentParams.navigation &&
+    (currentParams.navigation || currentParams.navigation === false) &&
     navigation &&
     !navigation.prevEl &&
     !navigation.nextEl

diff --git a/src/svelte/update-swiper.js b/src/svelte/update-swiper.js
@@ -30,7 +30,7 @@ function updateSwiper(swiper, passedParams, changedParams) {
     changedParams.includes('pagination') &&
     passedParams.pagination &&
     passedParams.pagination.el &&
-    currentParams.pagination &&
+    (currentParams.pagination || currentParams.pagination === false) &&
     pagination &&
     !pagination.el
   ) {
@@ -41,7 +41,7 @@ function updateSwiper(swiper, passedParams, changedParams) {
     changedParams.includes('scrollbar') &&
     passedParams.scrollbar &&
     passedParams.scrollbar.el &&
-    currentParams.scrollbar &&
+    (currentParams.scrollbar || currentParams.scrollbar === false) &&
     scrollbar &&
     !scrollbar.el
   ) {
@@ -53,7 +53,7 @@ function updateSwiper(swiper, passedParams, changedParams) {
     passedParams.navigation &&
     passedParams.navigation.prevEl &&
     passedParams.navigation.nextEl &&
-    currentParams.navigation &&
+    (currentParams.navigation || currentParams.navigation === false) &&
     navigation &&
     !navigation.prevEl &&
     !navigation.nextEl

diff --git a/src/vue/update-swiper.js b/src/vue/update-swiper.js
@@ -30,7 +30,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
     changedParams.includes('pagination') &&
     passedParams.pagination &&
     passedParams.pagination.el &&
-    currentParams.pagination &&
+    (currentParams.pagination || currentParams.pagination === false) &&
     pagination &&
     !pagination.el
   ) {
@@ -41,7 +41,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
     changedParams.includes('scrollbar') &&
     passedParams.scrollbar &&
     passedParams.scrollbar.el &&
-    currentParams.scrollbar &&
+    (currentParams.scrollbar || currentParams.scrollbar === false) &&
     scrollbar &&
     !scrollbar.el
   ) {
@@ -53,7 +53,7 @@ function updateSwiper(swiper, slides, passedParams, changedParams) {
     passedParams.navigation &&
     passedParams.navigation.prevEl &&
     passedParams.navigation.nextEl &&
-    currentParams.navigation &&
+    (currentParams.navigation || currentParams.navigation === false) &&
     navigation &&
     !navigation.prevEl &&
     !navigation.nextEl