fix: fallback $selector to $wrapperEl if no children exist (#5173)

nolimits4web · Nov 10, 2021 · d8b4ca1 · d8b4ca1
1 parent 815e837
commit d8b4ca1
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/cypress/integration/modules/core.js b/cypress/integration/modules/core.js
@@ -468,4 +468,29 @@ context('Core', () => {
     cy.get(`.swiper-scrollbar`).should('exist');
     cy.get(`.swiper-pagination`).should('exist');
   });
+
+  it('allow init empty Swiper', () => {
+    cy.window().then(async (_window) => {
+      _window.document.body.innerHTML = `
+      <div class="swiper-container">
+        <div class="swiper-wrapper"></div>
+        <div class="swiper-slide"></div>
+      </div>
+      `;
+      _window.swiperRef = new _window.Swiper('.swiper-container', {
+        loop: true,
+        loopedSlides: 0,
+        loopPreventsSlide: false,
+        on: {
+          init: () => {
+            cy.get('.swiper-slide').then((slide) => {
+              _window.swiperRef.addSlide(0, slide);
+            });
+          },
+        },
+      });
+      return _window.swiperRef;
+    });
+    cy.getActiveSlide();
+  });
 });
diff --git a/src/core/loop/loopCreate.js b/src/core/loop/loopCreate.js
@@ -6,7 +6,8 @@ export default function loopCreate() {
   const document = getDocument();
   const { params, $wrapperEl } = swiper;
   // Remove duplicated slides
-  const $selector = $($wrapperEl.children()[0].parentNode);
+  const $selector =
+    $wrapperEl.children().length > 0 ? $($wrapperEl.children()[0].parentNode) : $wrapperEl;
   $selector.children(`.${params.slideClass}.${params.slideDuplicateClass}`).remove();
 
   let slides = $selector.children(`.${params.slideClass}`);