Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): setElement call updateInitSwiper bug #5296

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix(angular): setElement call updateInitSwiper bug #5296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d036c3
fix(angular): setElement call updateInitSwiper bug
vltansky Dec 16, 2021
f57ad0b
Update swiper.component.ts
nolimits4web Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/angular/src/swiper.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,8 @@ export class SwiperComponent implements OnInit {
) {}

private _setElement(el: ElementRef, ref: any, update: string, key = 'el') {
if (ref && el && el.nativeElement) {
if (!ref && !el) return;
if (el.nativeElement) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have error in this line
core.js:6486 ERROR TypeError: Cannot read properties of undefined (reading 'nativeElement')
can we convert this line to
if(el?.nativeElement) {

if (ref[key] === el.nativeElement) {
return;
}
Expand Down