fix(modules/*): filter out falsy elements #6823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. I have not linked this PR to an issue because I can't provide my employer's application as a demo, and it would take vastly more time to strip it down to a working reproduction that I could get permission to share, than it would for the validity of the code fix to be assessed.
Under some circumstances when the the a11y module calls
destroy()
in response to receiving adestroy
event, it throws an exception (which can't be easily handled due to the asynchronicity).When the elements are retrieved from the swiper instance's navigation property:
let { nextEl, prevEl } = swiper.navigation ? swiper.navigation : {};
evidently they are arrays containing
undefined
.The conservative change I have made and which I have validated fixes the problem is to extend the existing truthiness filter in
makeElementsArray
for the single element case to the case when the input is already an array.