Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialSlide #7216 #7228

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

yasuhiro-yamamoto
Copy link
Contributor

Fixed behavior where the combination of 'initialSlide:0' and 'slidesPerView:auto' would shift the first slide position

  • getPropertyValue has an error when getting a decimal point value.
  • 'slidesPerView:auto' caused an error in the actual number of slides displayed and the calculated number of slides displayed due to the error.

yasuhiro-yamamoto and others added 2 commits December 3, 2023 16:40
Fixed behavior where the combination of 'initialSlide:0' and
'slidesPerView:auto' would shift the first slide position
@nolimits4web nolimits4web merged commit e5c04c3 into nolimits4web:master Feb 5, 2024
3 checks passed
@nolimits4web
Copy link
Owner

Merged, thanks!

@yasuhiro-yamamoto yasuhiro-yamamoto deleted the fix/7216 branch February 8, 2024 00:05
@JarvisChao
Copy link

When setting slide width to a larger value, it still show the last slide on load.

https://codepen.io/jarvis73045/pen/MWxxWjR

@yasuhiro-yamamoto
Copy link
Contributor Author

@JarvisChao @nolimits4web

I appreciate you taking the time to report this problem.

Through your detailed bug report, I was able to reproduce and diagnose the cause of the slide index shifting incorrectly.

Based on the investigation, I have implemented a solution by modifying the slide index calculation logic when moving to the initial displayed slide.

I opened a new pull request with the fix so we can get this resolved. (#7319)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants