Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#23): Fixes the timestamps and gregorian seconds #24

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix(#23): Fixes the timestamps and gregorian seconds #24

merged 2 commits into from
Mar 15, 2024

Conversation

josecriane
Copy link
Member

closes #23

@josecriane josecriane added the bug Something isn't working label Mar 15, 2024
javiergarea
javiergarea approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@javiergarea javiergarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

test/ncalendar_SUITE.erl Show resolved Hide resolved
@josecriane josecriane merged commit 6fa2113 into main Mar 15, 2024
1 check passed
@josecriane josecriane deleted the fix/#23-fixes-timestamp-gregorian-seconds branch March 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiergarea javiergarea javiergarea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The same date with different timezone must be a different timestamp and different gregorian seconds.
2 participants
@josecriane @javiergarea