New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature -- Allow for multiple scatterplots #47

Merged

bmschmidt merged 1 commit into nomic-ai:master from gerstej9:james/multiple-plots

Aug 29, 2022

Contributor

gerstej9 commented Aug 29, 2022

What this PR does

Allows for plotId parameter in Scatterplot initialization
PlotId is incorporated into canvas, container, and svg classes and Id's
Parameter includes default value to maintain existing functionality
Removes console.log on line 18229 as it was running indefinitely in Storybook

Example of two plots on same page

Example of changed classes and ids


          changes made to allow for multiple plots with plotId parameter passed…

c340480

… in at ininitialization

bmschmidt approved these changes

View reviewed changes

Collaborator

bmschmidt left a comment

Thanks for this, a very useful feature I have not gotten around to implementing and a sensible approach.

bmschmidt merged commit b57e6a2 into nomic-ai:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet