Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bindings to match new API #2240

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

Noofbiz
Copy link
Contributor

@Noofbiz Noofbiz commented Apr 19, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • [ X ] I have performed a self-review of my code.
  • [ N/A ] If it is a core feature, I have added thorough tests.
  • [ X ] I have added thorough documentation for my code.
  • [ X ] I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • [ X ] If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

When trying out the golang bindings, I found it couldn't build the tool because the API has changed since it's last been updated. I added the new parts of the API so it does build. I also updated the example and README to match the updated API.

Steps to Reproduce

If you follow the steps in the readme and try to make the bindings, you get an error because the C-api has changed.

Notes

I'd like to work more on the bindings. The tests need to be updated, and the API actually has new features that aren't implemented in golang yet that I'd like to add.

Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jerry Caligiure added 2 commits April 19, 2024 14:38
Signed-off-by: Jerry Caligiure <[email protected]>
Signed-off-by: Jerry Caligiure <[email protected]>
@manyoso manyoso merged commit 1b87aa2 into nomic-ai:main Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants