Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout action to v4 in codespell workflow #2414

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sunsided
Copy link
Contributor

@sunsided sunsided commented Jun 5, 2024

Describe your changes

This addresses the "Node.js 16 actions are deprecated" warning in GitHub Action runs of the codespell workflow by increasing the checkout action's version to v4.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Previous runs show the deprecation warning Node.js 16 actions are deprecated, e.g. on this run

Copy link
Member

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cebtenzzre
Copy link
Member

Actually, you need to sign off on your commit. I'm not sure why that check didn't run.

This addresses the "Node.js 16 actions are deprecated" warning in
GitHub Action runs of the codespell workflow.

Signed-off-by: Markus Mayer <[email protected]>
@sunsided
Copy link
Contributor Author

sunsided commented Jun 5, 2024

@cebtenzzre Done 🫡

@cebtenzzre cebtenzzre merged commit 69f766c into nomic-ai:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants