backend: fix a crash on inputs greater than n_ctx #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression in commit 4fc4d94 ("fix chat-style prompt templates (#1970)"), which moved some return statements into a new function (LLModel::decodePrompt) without making them return from the parent as well. Signed-off-by: Jared Van Bortel <[email protected]>
manyoso
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in commit 4fc4d94 ("fix chat-style prompt templates (#1970)"), which moved some return statements into a new function (LLModel::decodePrompt) without making them return from the parent as well.
Summary:
Fixes crash on inputs greater than
n_ctxby updatingLLModel::decodePromptto return a boolean and handle errors appropriately.Key points:
gpt4all-backend/llmodel.h:LLModel::decodePromptreturn type fromvoidtobool.gpt4all-backend/llmodel_shared.cpp:LLModel::promptto handledecodePromptreturn value and exit on error.LLModel::decodePromptto returnfalseon errors andtrueon success.Generated with ❤️ by ellipsis.dev