Fix placement of our thumbs down dialog and datalake opt-in dialog. #2540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the thumbs down dialog and the datalake opt-in dialog are misplaced. This PR uses https://doc.qt.io/qt-6/qml-qtquick-controls-overlay.html to fix.
Summary:
Fixes the placement of
ThumbsDownDialog
andMyDialog
by updating their positioning logic.Key points:
ThumbsDownDialog
positioning ingpt4all-chat/qml/ChatView.qml
to center usingparent
dimensions.parent
ofDialog
toOverlay.overlay
ingpt4all-chat/qml/MyDialog.qml
for correct placement.Generated with ❤️ by ellipsis.dev