Fixes for issue #2519. #2543
Merged
Fixes for issue #2519. #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using a signal to post process the text. This is still not ideal in that we want to move to preprocessing the text in the future and to do so by streaming the content in rather than replacing it all at the same time, but it does fix a hang that we experience with an infinite recursive loop of text changed signals in the markdown processing. This fixes issue #2519. Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Adam Treat <[email protected]>
…activity on idle? Signed-off-by: Adam Treat <[email protected]>
cebtenzzre
requested changes
Jul 8, 2024
Signed-off-by: Adam Treat <[email protected]>
Should be fixed now. |
Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send text directly into the text document from the chat view rather than using a signal to post process the text. This is still not ideal in that we want to move to preprocessing the text in the future and to do so by streaming the content in rather than replacing it all at the same time, but it does fix a hang that we experience with an infinite recursive loop of text changed signals in the markdown processing.
This fixes issue #2519.
Summary:
Fixes issue #2519 by sending text directly to the text document in the chat view, avoiding infinite recursive loops during markdown processing.
Key points:
forceUpdatemethod fromgpt4all-chat/chatmodel.h.valueChangedsignal inChatModelclass ingpt4all-chat/chatmodel.h.updateValuemethod inChatModelto emitvalueChangedsignal.m_textDocumentwithm_quickTextDocumentinChatViewTextProcessorclass ingpt4all-chat/chatviewtextprocessor.cppandgpt4all-chat/chatviewtextprocessor.h.setValuemethod toChatViewTextProcessorclass to set plain text directly.gpt4all-chat/qml/ChatView.qmlto usetextProcessor.setValue(value)instead ofchatModel.forceUpdate(index).Generated with ❤️ by ellipsis.dev