Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for GPT-J models. #2676

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Remove support for GPT-J models. #2676

merged 3 commits into from
Jul 17, 2024

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Jul 16, 2024

No description provided.

@manyoso manyoso requested a review from cebtenzzre July 16, 2024 15:45
Copy link
Member

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@manyoso
Copy link
Collaborator Author

manyoso commented Jul 17, 2024

See if it is good now...

@manyoso manyoso requested a review from cebtenzzre July 17, 2024 13:58
@manyoso manyoso dismissed cebtenzzre’s stale review July 17, 2024 13:59

Changes requested have been made

Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre linked an issue Jul 17, 2024 that may be closed by this pull request
All supported models are now converted using llama.cpp's conversion
scripts.

Signed-off-by: Jared Van Bortel <[email protected]>
@manyoso manyoso merged commit ca72428 into main Jul 17, 2024
6 of 20 checks passed
cebtenzzre added a commit that referenced this pull request Jul 18, 2024
This fixes a regression in commit ca72428 ("Remove support for GPT-J
models. (#2676)").

Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre added a commit that referenced this pull request Jul 18, 2024
This fixes a regression in commit ca72428 ("Remove support for GPT-J
models. (#2676)").

Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre added a commit that referenced this pull request Jul 18, 2024
This fixes a regression in commit ca72428 ("Remove support for GPT-J
models. (#2676)").

Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre added a commit that referenced this pull request Jul 18, 2024
This fixes a regression in commit ca72428 ("Remove support for GPT-J
models. (#2676)").

Signed-off-by: Jared Van Bortel <[email protected]>
manyoso pushed a commit that referenced this pull request Jul 19, 2024
ThiloteE added a commit that referenced this pull request Jul 19, 2024
### What changed:

Updates Readme.md of gpt4all-chat

- updates features
- removes feature wish-list
- removes any mention of gpt-j since support for it has been removed with #2676

### Motivation for pull-request:

1. Remove potential cause for duplication and conflicts between documentation on website and the wiki.
2. Readme should be future proof, so handle wish-list and roadmap via issue tracker.

Signed-off-by: ThiloteE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move our GPT-J implementation into llama.cpp (or drop it entirely)
2 participants