-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show scrollbar in CollectionsDrawer as needed #2691
Show scrollbar in CollectionsDrawer as needed #2691
Conversation
Make the scrollbar visible when there are more collections to display. Signed-off-by: Cosmic Snow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I need to look at this. If you look at the ListView right below it ... it has a Scrollbar that I think should work.
Yes, please do. I was suprised to find a ScrollView already in place, but with the scrollbar turned off. The change works, but it feels like I'm missing something. |
Oh weird. If I set Edit: Maybe the intended way to do it was keeping the original I admit I don't really understand why it behaves the way it does. |
Signed-off-by: Cosmic Snow <[email protected]>
Signed-off-by: Cosmic Snow <[email protected]>
Fixes #2573.
Describe your changes
Make the scrollbar visible (
AsNeeded
) when there are more collections to display than what fits the height.Issue ticket number and link
Checklist before requesting a review
Demo
Before: see linked issue
After:
Steps to Reproduce
Have more collections than what fits in the right drawer in chat.
Notes
Maybe I'm missing something here, but there already was a
ScrollView
in place, just the scrollbar turned off for some reason.So this might not be the proper way to address the issue.