Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scrollbar in CollectionsDrawer as needed #2691

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

cosmic-snow
Copy link
Collaborator

@cosmic-snow cosmic-snow commented Jul 18, 2024

Fixes #2573.

Describe your changes

Make the scrollbar visible (AsNeeded) when there are more collections to display than what fits the height.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Before: see linked issue
After:
image

Steps to Reproduce

Have more collections than what fits in the right drawer in chat.

Notes

Maybe I'm missing something here, but there already was a ScrollView in place, just the scrollbar turned off for some reason.
So this might not be the proper way to address the issue.

Make the scrollbar visible when there are more collections to display.

Signed-off-by: Cosmic Snow <[email protected]>
@cosmic-snow cosmic-snow added chat gpt4all-chat issues chat-ui-ux Issues related to the look and feel of GPT4All Chat. labels Jul 18, 2024
Copy link
Collaborator

@manyoso manyoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I need to look at this. If you look at the ListView right below it ... it has a Scrollbar that I think should work.

@cosmic-snow
Copy link
Collaborator Author

Yes, please do. I was suprised to find a ScrollView already in place, but with the scrollbar turned off. The change works, but it feels like I'm missing something.

@cosmic-snow
Copy link
Collaborator Author

cosmic-snow commented Jul 18, 2024

Oh weird. If I set anchors.left: listView.right - 20 in the ListView's scrollbar instead, then I get one. Although not where I expected it.

Edit: Maybe the intended way to do it was keeping the original AlwaysOff but setting the nested scrollbar to anchors.right: listView.right instead of anchors.left: listView.right?

I admit I don't really understand why it behaves the way it does.

@cosmic-snow
Copy link
Collaborator Author

How accurate is Qt across platforms? This looks fine for me now on Windows.

Screenshot of bottom right area, scrolled all the way down:
image

@cosmic-snow cosmic-snow requested a review from manyoso July 18, 2024 15:56
@manyoso manyoso merged commit 54ed309 into nomic-ai:main Jul 19, 2024
2 checks passed
@cosmic-snow cosmic-snow deleted the collections-drawer-scrolling branch July 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat gpt4all-chat issues chat-ui-ux Issues related to the look and feel of GPT4All Chat.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing LocalDocs Scrollbar
2 participants