chat: fix comparison of prerelease versions #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <[email protected]>
This isn't such a problem for official stable releases, but for development versions (-dev0) and prereleases (-rc1), the version syntax needs to be parsed more carefully. Signed-off-by: Jared Van Bortel <[email protected]>
3.0.0 is actually the same version as 3.0. Signed-off-by: Jared Van Bortel <[email protected]>
manyoso
approved these changes
Jul 29, 2024
Signed-off-by: Jared Van Bortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering before this PR (not deterministic, but this is one possibility):
Ordering after this PR:
The order is now deterministic as it never ignores any part of the version. Pre-release versions compare as less than the stable releases that come after.
This means we shouldn't use post-release suffixes (e.g. v3.1.1-web_search_beta_2 after v3.1.1) unless we can agree on what pre-release and post-release suffixes look like (maybe -dev and -rc are the only pre-release suffixes?)We agreed to use -devX and -rcX for pre-releases and treat everything else as a post-release.This PR also fixes an assertion failure caused by the combination of #2759 and #2762.