forked from jitsi/jicofo
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Use RocksXmppPrecisStringprep for striter JID validation. (jits…
- Loading branch information
Showing
5 changed files
with
139 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
jicofo/src/test/kotlin/org/jitsi/jicofo/xmpp/JidTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /* | ||
| * Jicofo, the Jitsi Conference Focus. | ||
| * | ||
| * Copyright @ 2024-Present 8x8, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.jitsi.jicofo.xmpp | ||
|
|
||
| import io.kotest.assertions.throwables.shouldThrow | ||
| import io.kotest.assertions.withClue | ||
| import io.kotest.core.spec.IsolationMode | ||
| import io.kotest.core.spec.style.ShouldSpec | ||
| import io.kotest.core.test.TestCase | ||
| import io.kotest.matchers.shouldNotBe | ||
| import io.kotest.matchers.types.shouldBeInstanceOf | ||
| import org.jxmpp.JxmppContext | ||
| import org.jxmpp.jid.impl.JidCreate | ||
| import org.jxmpp.stringprep.XmppStringprepException | ||
| import org.jxmpp.stringprep.rocksxmppprecis.RocksXmppPrecisStringprep | ||
|
|
||
| /** | ||
| * Test JID parsing. The lists below are based on the jxmpp corpora here, plus a couple additional ones: | ||
| * https://github.com/igniterealtime/jxmpp/tree/master/jxmpp-strings-testframework/src/main/resources/xmpp-strings/jids/valid/main | ||
| * https://github.com/igniterealtime/jxmpp/blob/master/jxmpp-strings-testframework/src/main/resources/xmpp-strings/jids/invalid/main | ||
| */ | ||
| class JidTest : ShouldSpec() { | ||
| override fun isolationMode(): IsolationMode { | ||
| return IsolationMode.SingleInstance | ||
| } | ||
| override suspend fun beforeAny(testCase: TestCase) { | ||
| super.beforeAny(testCase) | ||
| initializeSmack() | ||
| } | ||
|
|
||
| init { | ||
| context("Parsing valid JIDs") { | ||
| JxmppContext.getDefaultContext().xmppStringprep.shouldBeInstanceOf<RocksXmppPrecisStringprep>() | ||
| validJids.forEach { | ||
| withClue(it) { | ||
| JidCreate.from(it) shouldNotBe null | ||
| } | ||
| } | ||
| } | ||
| context("Parsing invalid JIDs") { | ||
| JxmppContext.getDefaultContext().xmppStringprep.shouldBeInstanceOf<RocksXmppPrecisStringprep>() | ||
| invalidJids.forEach { | ||
| withClue(it) { | ||
| shouldThrow<XmppStringprepException> { | ||
| JidCreate.from((it)) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| val validJids = listOf( | ||
| "[email protected]", | ||
| "[email protected]/foo", | ||
| "[email protected]/foo bar", | ||
| "[email protected]/foo@bar", | ||
| "foo\\[email protected]", | ||
| "[email protected]", | ||
| "fuß[email protected]", | ||
| "π@example.com", | ||
| "Σ@example.com", | ||
| "ς@example.com", | ||
| "[email protected]/♚", | ||
| "example.com", | ||
| "example.com/foobar", | ||
| "a.example.com/[email protected]", | ||
| "server/resource@foo", | ||
| "server/resource@foo/bar", | ||
| "user@CaSe-InSeNsItIvE", | ||
| "[email protected]", | ||
| // "user@[2001:638:a000:4134::ffff:40]", | ||
| // "user@[2001:638:a000:4134::ffff:40%eno1]", | ||
| // "user@averylongdomainpartisstillvalideventhoughitexceedsthesixtyfourbytelimitofdnslabels", | ||
| "long-conference-name-1245c711a15e466687b6333577d83e0b@" + | ||
| "conference.vpaas-magic-cookie-a32a0c3311ee432eab711fa1fdf34793.8x8.vc", | ||
| "[email protected]/🍺" | ||
| ) | ||
|
|
||
| val invalidJids = listOf( | ||
| "jul\u0001[email protected]", | ||
| "\"juliet\"@example.com", | ||
| "foo [email protected]", | ||
| // This fails due to a corner case in JidCreate when "example.com" is already cached as a DomainpartJid | ||
| // "@example.com/", | ||
| "henryⅣ@example.com", | ||
| "♚@example.com", | ||
| "juliet@", | ||
| "/foobar", | ||
| "node@/server", | ||
| "@server", | ||
| "@server/resource", | ||
| "@/resource", | ||
| "@/", | ||
| "/", | ||
| "@", | ||
| "user@", | ||
| "user@@", | ||
| "user@@host", | ||
| "user@@host/resource", | ||
| "user@@host/", | ||
| "[email protected]/x", | ||
| "[email protected]@example.org", | ||
| "foo\u0000[email protected]", | ||
| "foobar@ex\u0000ample.org" | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters