Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set renovate nodejs to below 21 #845

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

weeman1337
Copy link
Contributor

Should prevent renovate from updating major node versions like here #844

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 26fcde6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@weeman1337 weeman1337 force-pushed the nic/fix/nodejs-version-boundaries branch from 7870737 to 2314b5d Compare November 13, 2024 09:23
@weeman1337 weeman1337 marked this pull request as ready for review November 13, 2024 09:27
@weeman1337 weeman1337 requested a review from a team as a code owner November 13, 2024 09:27
Copy link
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think engines also applies to something other than nodejs, blocking by requesting changes to check...

mgcm
mgcm previously approved these changes Nov 13, 2024
@HarHarLinks
Copy link
Contributor

Here, this change will fix also yarn to <21, which technically works but is unclean, so I object.

#833

Signed-off-by: Michael Weimann <[email protected]>
@weeman1337
Copy link
Contributor Author

I think engines also applies to something other than nodejs, blocking by requesting changes to check...

node is now pinned instead of engines

@weeman1337 weeman1337 merged commit f83c1d8 into main Nov 13, 2024
4 checks passed
@weeman1337 weeman1337 deleted the nic/fix/nodejs-version-boundaries branch November 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants