Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Install script hangs when using ionic #8

Closed
ptarjan opened this issue Sep 25, 2015 · 3 comments
Closed

Install script hangs when using ionic #8

ptarjan opened this issue Sep 25, 2015 · 3 comments
Labels

Comments

@ptarjan
Copy link
Contributor

ptarjan commented Sep 25, 2015

I ran this:

$ ionic plugin add cordova-hot-code-push-plugin
Updated the hooks directory to have execute permissions
Fetching plugin "cordova-hot-code-push-plugin" via npm
Installing "cordova-hot-code-push-plugin" for android
Plugin "cordova-hot-code-push-plugin" already installed on ios.
======== CHCP after plugin add process ========
Can't find module prompt, running npm install
Package prompt is installed
Can't find module xml2js, running npm install
Package xml2js is installed
All dependency modules are installed.

To make the development process more easy for you - we developed CLI client for our plugin.
For more information please visit https://github.com/nordnet/cordova-hot-code-push-cli
Would you like to install CLI client for the plugin?(y/n): y

And now it is hung. pstree only gives me:

 |         |     \--- 06073 pt node /usr/local/bin/cordova plugin add cordova-hot-code-push-plugin

with no children. Doing it again with cordova works:

$ cordova plugin add cordova-hot-code-push-plugin
Updated the hooks directory to have execute permissions
Fetching plugin "cordova-hot-code-push-plugin" via npm
Plugin "cordova-hot-code-push-plugin" already installed on android.
Plugin "cordova-hot-code-push-plugin" already installed on ios.
======== CHCP after plugin add process ========
Node module prompt is found
Package prompt is installed
Node module xml2js is found
Package xml2js is installed
All dependency modules are installed.
To make the development process more easy for you - we developed CLI client for our plugin.
For more information please visit https://github.com/nordnet/cordova-hot-code-push-cli
Would you like to install CLI client for the plugin?(y/n): y
Installing CHCP CLI client...
CLI for plugin is installed. You are good to go. For more information use "cordova-hcp --help"
=================================================
@ptarjan ptarjan changed the title Install script hangs if you answer yes Install script hangs Sep 25, 2015
@ptarjan ptarjan changed the title Install script hangs Install script hangs when using ionic Sep 25, 2015
@nikDemyankov
Copy link
Member

Thanks for the report. I'm planning to work on Ionic related issues of the plugin on the next week, so, will see how it goes.

nikDemyankov added a commit that referenced this issue Oct 1, 2015
Removed input for CLI installation: user will have to do it manually. Fixes #11 and #8
@nikDemyankov
Copy link
Member

Updated installation hook - no more user input requests for CLI client. ionic plugin add cordova-hot-code-push-plugin will not hang. Issue will be closed after the release.

@nikDemyankov
Copy link
Member

Fixed in version 1.0.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants