This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
Make plugin compatible with other plugins #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 18, 2016 17:10
|
Thanks, will check it out! |
nikDemyankov
added a commit
that referenced
this pull request
Jan 20, 2016
Plugin should now work with other plugins, that are using EventBus. Thanks to @Steffaan
|
Merged, thanks for help! Can you also send a link to the plugin, that was crashing it? |
|
It was crashing the app when we used it together with: https://github.com/transistorsoft/cordova-background-geolocation-lt We use the premium version of that plugin. |
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin was not compatible with other plugins using Eventbus. As soon as you add another plugin that uses Eventbus (like background-geolocation) the app crashes. Fixed.