Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org levels should not be the same color. #81

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

C0DK
Copy link
Contributor

@C0DK C0DK commented Dec 2, 2019

I'm using the whole Frost palette now.

Casper Weiss Bang added 2 commits December 2, 2019 19:32
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @C0DK 👋, thanks for your contribution 👍
LGTM 🚀

It used nord8 for all levels to match the style of Markdown syntax in Emacs as well as other projects, but I guess it makes sense for this package to use different colors since users might expect it. Also looks like the default style of the Org-Mode package uses different colors.

@arcticicestudio arcticicestudio merged commit e095a86 into nordtheme:develop Dec 3, 2019
arcticicestudio pushed a commit that referenced this pull request Dec 3, 2019
Fixed a syntax error introduced in GH-81 (PR) that added an extra brace. This resulted in error when trying to load the theme.
@C0DK C0DK deleted the patch-1 branch December 3, 2019 21:09
@arcticicestudio
Copy link
Contributor

Release Note Resources

Before

After

arcticicestudio pushed a commit that referenced this pull request Jan 8, 2020
It now uses the whole "Frost" palette.
It used `nord8` for all levels before to match the style of Markdown
syntax in Emacs as well as other projects, but it makes sense for this
package to use different colors since users might expect it.
This also matches the default style of the Org-Mode package that makes
use of different colors.

Additionaly this comit removed a duplicate line.
arcticicestudio pushed a commit that referenced this pull request Jan 8, 2020
Fixed a syntax error introduced in GH-81 (PR) that added an extra brace. This resulted in error when trying to load the theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants