Underline in search highlight

[ghost]

I recently started using the nord-vim colorscheme and so far I am very pleased. Great job. I have a question though regarding search highlight. When search highlight is enabled the searched item is both hightlighted and underlined. Is it possible to disable the underlining? See screenshot below.

[arcticicestudio]

The underline style has been added in #41 to improve the currently selected element at the cursor position when there are multiple search results, otherwise only the cursor indicates the current position. More details are posted in the linked PR.

It might be a good idea to make the underline effect configurable which can also prevent incompatibility problems with plugins that modify the styling of search results. Feel free to implement it as theme configuration and submit a PR, otherwise I'll add it to the backlog so someone can take care of it 😄

[ghost]

Thanks for the answer. I will consider submitting a PR.

[dylnmc]

/me sighs ... midterms 😿

[dylnmc]

@hejersbo It is a nice colorscheme, indeed! Hoorah.

Regarding your fix: the fix you seek seems very specific. If you do not want the underline there for only the search, I would suggest putting this before calling colorscheme nord in your vimrc:

augroup NordFixes
    autocmd!
    autocmd ColorScheme nord highlight IncSearch cterm=NONE
augroup end

An option in nord, itself, for disabling underline in only IncSearch seems very specific, but that's only my opinion.

With the pull request I submitted in #109 you will be able to completely disable underlines with let g:nord_underline = 0, if that is what you desire.

[arcticicestudio]

@hejersbo
Sorry for the delay, I've had no free time (job 👨‍⚕️, study 📖, life 🏋️‍♂️ etc.) to work on my or any other OSS project (see Tweets 🐦 from April and June), but from the beginning of July I finished my studies and can finally spend time on OSS again 💚

Like @dylnmc already mentioned a option to only disable underlines for the IncSearch is too specific and can simply be achieved with the custom scoped overrides. To disable underlines globally a new configuration has been implemented which has been shipped with release version 0.9.0.