Optional Underline and Spell Foreground Colors #109
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #106 (now
SpellBad
et. al. have appropriately colored foreground colors).Also, this fix allows the user to disable underline with
let g:nord_underline = 0
. This applies to all underlines globally.I feel like I might have a go at refactoring nord.vim to be slightly more efficient and concise while retaining all functionality and customization (and potentially adding more where it might be a good idea), but this fix works for now.
Although, it might appear strange to set
s:underline = "NONE,"
, you can test for yourself and see that it works to disable underline without affecting any otherterm=
attributes.This also is referenced in #105