Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic support #13

Closed
kepbod opened this issue Jan 13, 2017 · 4 comments
Closed

Italic support #13

kepbod opened this issue Jan 13, 2017 · 4 comments

Comments

@kepbod
Copy link
Contributor

kepbod commented Jan 13, 2017

Is there any plan to support Italic?

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jan 14, 2017

Can you explain what exactly should be supported?

I try to limit the syntax highlighting to colors for port projects which do not support font attributes by default. Vim and all other terminal based projects in general are affected by this cause there can still be problems when the italic attribute is set for groups and the terminal is not able to handle it.

Besides that there are not many elements that I'd like to use italic fonts for. I only use it for static methods/functions in OOP languages that provide this mechanism.

@kepbod
Copy link
Contributor Author

kepbod commented Jan 14, 2017

Just like described here. Supporting italic is just an advice, and I think this colorscheme is cool enough now. Thanks for developing such great colorscheme.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jan 24, 2017

I'll try to implement a global variable to enable/disable italics when I'm back home next weekend. I think the implementation ifself isn't the problem at all, but the fact that Nord tries to avoid italics 😄

Currently I see no use for italic styled fonts except for some really special cases. Maybe it could be used for the Special group or if the language syntax highlighting is advanced enough to differ between normal and static functions/methods like I described for IntelliJ Idea above.

Some themes like to use italic fonts for comments, but in my option this makes it even harder to read 😟
Instead comments should be colorized in a decent, not disturbing color to keep the focus on the code.

Please feel free to tell me which parts of the theme you'd like to see using italics, maybe we can introduce another option for it like e.g. "Use italic font for comments" or something like this.

@kepbod
Copy link
Contributor Author

kepbod commented Jan 24, 2017

I agree to most of what you said. Thanks so much for supporting this feature. Most theme used italics for comments, so I think using italic font for comments is enough. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants