Current argument in function signature preview of jedi-vim not properly highlighted

[mkalinski]

Jedi-vim is a popular Vim plugin for python programming.

One of its features is a live preview of the signature of the function that is being currently typed. Current position in the argument list is highlighted, but in nord-vim this is not visible. That's because jedi-vim assumes that TabLine and CursorLine groups are highlighted differently, but they aren't in nord-vim.

From https://github.com/davidhalter/jedi-vim/blob/master/after/syntax/python.vim:

    if exists('g:colors_name')
        hi def link jediFunction CursorLine
        hi def link jediFat TabLine
    else
        hi jediFunction term=NONE cterm=NONE ctermfg=6 guifg=Black gui=NONE ctermbg=0 guibg=Grey
        hi jediFat term=bold,underline cterm=bold,underline gui=bold,underline ctermbg=0 guibg=#555555
    endif

Either TabLine and CursorLine should be highlighted differently, or the plugin-specific jediFunction and jediFat overridden (jediFat is the one that should stand out more).

[arcticicestudio]

I'll test it next weekend, but as far as I've seen your suggestion with overriding the methods sounds like a clean solution.
Changing the TabLine or CursorLine would break many other plugins that rely on this groups.

[arcticicestudio]

I've tested the auto completion feature today and for me the list looks fine.
The currently selected entry has a lighter background and the font using the main accent theme color nord8.

Can you please post a screenshot of your view, your .vimrc config and maybe some example code so I can try to reproduce it.

And by the way, this plugin is awesome! 😄
I'll definitely use it for my Python projects, thanks 👍

[mkalinski]

Yeah, this display is alright, I meant something different. I'll provide the screenshots.

Here is the function call signature prompt in the default theme:

Meanwhile in nord:

[arcticicestudio]

Thanks, this looks definitely worng 😆
I'll add support for it as soon as I've got some freetime for it 😄

[arcticicestudio]

Implemented optimized styles for the jediFunction and jediFat groups.

Before

After