-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odd Highlighting On Greek and Sub/Superscripts #149
Comments
It is more likely that the plugin uses custom syntax keys. This would require to add support for them to Nord to make it work properly. Could you please post the name and/or the link to the GitHub repository of the plugin? |
@arcticicestudio Certainly, it's Vimtex, and found here: Anything else I can do to help? |
Well, I reached out to @gillescastel and he said to add |
@duncanam Nice to hear it works fine now 🎉 |
I found some post here: Could we also do it for Nord? |
For anyone else running into this issue:
The full theme section of my
|
This works perfect. |
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <[email protected]> GH-256
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <[email protected]> Closes GH-256
@duncanam @xarthurx @Bobby-Huggins @nikinbaidarr Thanks for your help 👍 |
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in nordthemeGH-149, nordthemeGH-207 and nordthemeGH-211 with LaTeX and Pandoc being used by the reporters. PR nordthemeGH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <[email protected]> Closes nordthemeGH-256
After being able to successfully install and use Nord on vim quite nicely, I did notice a quirky thing that may or may not be intentional and I was wondering if there was a setting to turn it off or if it was indeed a bug. I am using a plugin in vim that will render some of my LaTeX expressions as Greek characters inline, and will apply sub and superscripts to them. The Nord theme seems to highlight these:
Current output: highlights Greek and sub/superscript
Desired output: no highlighting of Greek and sub/superscript
Is there anything I can do about this, or is just outright unsupported (which is fine too, although it would be neat if there was a solution).
The text was updated successfully, but these errors were encountered: