Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-plug support #43

Closed
dylnmc opened this issue Jul 17, 2017 · 5 comments · Fixed by #59
Closed

vim-plug support #43

dylnmc opened this issue Jul 17, 2017 · 5 comments · Fixed by #59
Labels
context-plugin context-ui type-improvement
Milestone
version-0.7.0

Comments

@dylnmc
Copy link
Contributor

dylnmc commented Jul 17, 2017 •
edited
Loading

plugDeleted links to Ignore and the result is invisible unless you have :set cursorline enabled and are on that line:

plug1
plug2

changing ctermfg to s:nord3_term and guibg to s:nord3_gui for Ignore seems like a good fix.
@arcticicestudio
Copy link
Contributor

Which OS, version of Vim/Neovim/Gvim and terminal emulator are you running?
I've tried to reproduce this but the line is visible whether with cursorline enabled or not.

gh-43-scrcast-vim-plug-clean

@dylnmc
Copy link
Contributor Author

dylnmc commented Jul 18, 2017 •
edited
Loading

Ok, I will check it out when I get back home. I was noticing this in gvim at work (windows), but I work in regular ole vim at home in urxvt, and I don't think I have noticed it there. Maybe it has something to do with the gui hl groups. Thanks

@dylnmc
Copy link
Contributor Author

dylnmc commented Jul 18, 2017 •
edited
Loading

This is set to correct color in term, but in gvim, it's invisible because plugDeleted links to Ignore which is set to ctermfg=0 ctermbg=bg by default.

(This occurs after you've selected 'Y' and deleted the plugin to be specific.)

@arcticicestudio
Copy link
Contributor

I'll try to reproduce it in gvim.

@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Sep 28, 2017
@arcticicestudio arcticicestudio changed the title Ignore hl group is invisible vim-plug support Sep 28, 2017
arcticicestudio added a commit that referenced this issue Sep 28, 2017
@arcticicestudio
Add plugin support for vim-plug
d3a9615 
This adds support for "junegunn/vim-plug" for the "PlugClean" command
which used the "Ignore" group for deleted directory listings resulting
in unreadable text when "cursorline" has been set.

GH-43
@arcticicestudio arcticicestudio mentioned this issue Sep 28, 2017
Merged
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Sep 28, 2017 •
edited
Loading

I've implemented optimized support for vim-plug in #59 which should work fine in gvim.

arcticicestudio added a commit that referenced this issue Sep 28, 2017
@arcticicestudio
Merge pull request #59 from arcticicestudio/improvement/gh-43-vim-plu…
e532b5d 
…g-support

Add plugin support for vim-plug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-plugin context-ui type-improvement
Projects
None yet
Milestone
version-0.7.0
Development

Successfully merging a pull request may close this issue.

Add plugin support for vim-plug nordtheme/vim
2 participants
@dylnmc @arcticicestudio