Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo bright background #52

Closed
dylnmc opened this issue Sep 20, 2017 · 2 comments · Fixed by #53
Closed

Todo bright background #52

dylnmc opened this issue Sep 20, 2017 · 2 comments · Fixed by #53
Labels
context-syntax scope-quality target-gvim target-neovim type-bug
Milestone
version-0.7.0

Comments

@dylnmc
Copy link
Contributor

dylnmc commented Sep 20, 2017 •
edited
Loading

Background for Todo isn't set manually and looks bad.

todo_pretty
todo_ugly

It looks good when cursorline is on, and you're on that line, but it looks bad when you move away.

I'll make pull request when I get home ... I'll just set background for term and gui to NONE, and hopefully, that'll do the trick.

cheers 😄

(ps if you don't see it in vim, I'm in gvim 😢 at work)
@dylnmc dylnmc mentioned this issue Sep 20, 2017
Merged
@dylnmc
Copy link
Contributor Author

dylnmc commented Sep 20, 2017 •
edited
Loading

looks like it was only for gvim. fixed it though.

Now it looks like (term) vim; here is fix:

todo_fixed

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Sep 22, 2017 •
edited
Loading

Thanks for the fix 👍

I need to remind myself to test in vim, neovim/macvim and gvim 😄

This also confirms that #34 was affected by this too.

/cc @KevinSjoberg

arcticicestudio added a commit that referenced this issue Sep 22, 2017
@arcticicestudio
Merge pull request #53 from dylnmc/fix-high-contrast-todo
063620f 
Fixes the yellow high contrast background color for TODO strings in
gvim/neovim.

GH-52
@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax scope-quality target-gvim target-neovim type-bug
Projects
None yet
Milestone
version-0.7.0
Development

Successfully merging a pull request may close this issue.

fixes Todo (gui) bg color (high-contrast)
3 participants
@dylnmc @arcticicestudio @svengreb