Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight support for diffAdded and diffRemoved #66

Closed
brandoniffert opened this issue Oct 25, 2017 · 5 comments · Fixed by #67
Closed

Add highlight support for diffAdded and diffRemoved #66

brandoniffert opened this issue Oct 25, 2017 · 5 comments · Fixed by #67

Comments

@brandoniffert
Copy link

screen shot 2017-10-25 at 8 53 58 am

vs

screen shot 2017-10-25 at 8 50 45 am

@dylnmc
Copy link
Contributor

dylnmc commented Oct 25, 2017

It's DiffAdd, DiffChange and DiffDelete in vim.

Are you in neovim? Also, how did you get to this diff? Did you use :diffthis or something? Or is this a plugin?

Thanks,
dylnmc


If you're in neovim, and this is a real thing, I'll hi linkDiffAdded to DiffAdd and DiffDeleted to DiffDelete when I get home.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 25, 2017

Thanks for your contribution, but the theme already supports highlighting for diff. The groups are named diffAdd and diffDelete.

The theme also provides a configuration to enable uniform diff backgrounds.

I've searched the official vim documentation, but the only groups listed are diffAdd and diffDelete.

@brandoniffert Is there any documentation about the groups you mentioned or are they maybe added by a plugin you're using?

@arcticicestudio arcticicestudio added hacktoberfest This repository participates in the Hacktoberfest status-pending reproduction labels Oct 25, 2017
@brandoniffert
Copy link
Author

Hmm, I can't seem to find docs on it either but I've had it in other colorschemes. It's in the vim source code for git.vim and diff.vim

I have vim set to my $EDITOR and when I run git commit --verbose it opens it in vim to edit and that's where I see this interface.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 26, 2017

Ah, I see 👀

I've scoured through the git log and saw that it was included in the theme in an earlier version, but I've removed it because it seemed like a deprecated group since it had no effect when used with vim -d / :diff.

I'll link the missing groups to their respective diff* group.

@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Oct 26, 2017
arcticicestudio added a commit that referenced this issue Oct 31, 2017
The official "git.vim" and "diff.vim" syntax uses different groups for
diff:

* diffAdded (1)
* diffRemoved (1)
* diffChanged (2)

This commit links these legacy groups to the official documented diff
groups.

References:
  (1) https://github.com/vim/vim/search?q=diffAdded+diffRemoved
  (2) https://github.com/vim/vim/search?q=diffChanged

GH-66
@arcticicestudio
Copy link
Contributor

Linked diffAdded and diffRemoved to their respective groups and the diffChanged group to DiffChange.

arcticicestudio added a commit that referenced this issue Oct 31, 2017
…ffAdded-and-diffRemoved

Link legacy diff groups for git.vim and diff.vim syntax
@arcticicestudio arcticicestudio removed their assignment Oct 31, 2017
@svengreb svengreb added context-syntax and removed hacktoberfest This repository participates in the Hacktoberfest labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants