Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust visual (selection) colour #7

Closed
scottwillmoore opened this issue Jan 1, 2017 · 6 comments
Closed

Adjust visual (selection) colour #7

scottwillmoore opened this issue Jan 1, 2017 · 6 comments

Comments

@scottwillmoore
Copy link

The visual selection colour defined by, call s:hi("Visual", "", s:nord2_gui, "", s:nord3_term, "", "") uses the same colour, s:nord3_term as comments do. This means that when selecting comments with visual regions you cannot read the selected area.

This could be easily resolved by making the visual region use the colour, s:nord1_term. This colour does not appear to clash with other syntax elements, and hence should be a better choice the visual region colour.

@arcticicestudio arcticicestudio self-assigned this Jan 2, 2017
arcticicestudio added a commit that referenced this issue Jan 2, 2017
Fixes unreadable (visual) selected comments.
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jan 2, 2017

Thanks for your report 👍
Even if comments are hard to read withnord1 as smooth and easy-on-the-eyes background color, it seems like it is the only solution to keep the style guideline with other port projects.

You can test the change by checking out the improvement/ghi-#7-adjust-visual-selection-colour branch.

Before

After

@scottwillmoore
Copy link
Author

Awesome, thank you for that!

Others may want to add the following patch to their .vimrc until a release is prepared (which I'm sure won't take long).

autocmd ColorScheme * highlight Visual ctermbg=0

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jan 2, 2017

🚢 Shipped in release version 0.2.0
If your're using vim-plug you can update to the latest version by running :PlugUpdate 😄

@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Jul 10, 2017
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
@clearissimple
Copy link

Would it be possible to adjust the style of visual selection to be a little more dominant in diff mode?
screenshot from 2018-10-25 11-28-22
In the screen shot above all but the last line are selected in the visual line selection mode.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 26, 2018

@clearissimple Have you tried if it works using the uniform diff background theme configuration?

@clearissimple
Copy link

Yes, it works. The uniform diff background mode is nice, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants