Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the neovim terminal cursor visible when out of terminal mode #101

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

meck
Copy link
Contributor

@meck meck commented Feb 18, 2018

In the neovim terminal when you exit the terminal mode and navigate around the terminal window, or to another window you loose track of the current cursor position if TermCursorNC is not set.

Copy link
Contributor

@dylnmc dylnmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I rarely use neovim, just adding approval since it checks out, looks good, and improves functionality

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for your contribution 👍

This is a nice improvement for neovim users. I've only added a small change request, apart from that everything looks fine.

colors/nord.vim Outdated
@@ -160,6 +160,7 @@ call s:hi("healthWarning", s:nord13_gui, s:nord1_gui, s:nord13_term, s:nord1_ter

"+- Neovim Terminal Colors -+
if has('nvim')
call s:hi("TermCursorNC", "", s:nord1_gui, "", s:nord1_term, "", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move the new line out of the if statement body and append it to the "+- Neovim Support -+ section above?

@arcticicestudio arcticicestudio removed their request for review February 21, 2018 10:00
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@dylnmc
Copy link
Contributor

dylnmc commented Feb 23, 2018

sidenote: when vim is compiled with --enable-terminal, this pull req also helps out, since TermCursorNC accurately describes the same thing in regular vim.

cheers ~

@arcticicestudio
Copy link
Contributor

@dylnmc Thanks for the info, haven't checked if vim also makes use of it. So maybe I'll move the definition out of the neovim specific group section later on 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants