-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the neovim terminal cursor visible when out of terminal mode #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I rarely use neovim, just adding approval since it checks out, looks good, and improves functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for your contribution 👍
This is a nice improvement for neovim users. I've only added a small change request, apart from that everything looks fine.
colors/nord.vim
Outdated
@@ -160,6 +160,7 @@ call s:hi("healthWarning", s:nord13_gui, s:nord1_gui, s:nord13_term, s:nord1_ter | |||
|
|||
"+- Neovim Terminal Colors -+ | |||
if has('nvim') | |||
call s:hi("TermCursorNC", "", s:nord1_gui, "", s:nord1_term, "", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move the new line out of the if
statement body and append it to the "+- Neovim Support -+ section above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
sidenote: when vim is compiled with cheers ~ |
@dylnmc Thanks for the info, haven't checked if vim also makes use of it. So maybe I'll move the definition out of the neovim specific group section later on 😄 |
In the neovim terminal when you exit the terminal mode and navigate around the terminal window, or to another window you loose track of the current cursor position if TermCursorNC is not set.