Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less obtrusive colors for terminal stl #103

Closed
wants to merge 3 commits into from
Closed

less obtrusive colors for terminal stl #103

wants to merge 3 commits into from

Conversation

dylnmc
Copy link
Contributor

@dylnmc dylnmc commented Feb 23, 2018

In vim, :terminal has a bright green StatusLineTerm and
StatusLineTermNC. This update guaruntees that both vim and neovim have
consistent StatusLine[NC] and StatusLineTerm[NC] colors.

In vim, :terminal has a bright green StatusLineTerm and
StatusLineTermNC. This update guaruntees that both vim and neovim have
consistent StatusLine[NC] and StatusLineTerm[NC] colors.
@dylnmc
Copy link
Contributor Author

dylnmc commented Feb 23, 2018

before:

screenshot from 2018-02-23 01-23-17

after:

screenshot from 2018-02-23 01-24-16

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

I'll test the changes this weekend and merge it.

@@ -147,10 +147,10 @@ call s:hi("PmenuSbar", s:nord4_gui, s:nord2_gui, "NONE", s:nord1_term, "", "")
call s:hi("PMenuSel", s:nord8_gui, s:nord3_gui, s:nord8_term, s:nord3_term, "", "")
call s:hi("PmenuThumb", s:nord8_gui, s:nord3_gui, "NONE", s:nord3_term, "", "")
call s:hi("SpecialKey", s:nord3_gui, "", s:nord3_term, "", "", "")
call s:hi("SpellBad", "", s:nord0_gui, "", "NONE", "undercurl", s:nord11_gui)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you've rebased this branch so this mixes two different issues. Can you please remove 4805611 again?

@dylnmc
Copy link
Contributor Author

dylnmc commented Mar 9, 2018

I was going to submit another PR, but things got mixed up. I'll certainly fix after exam+work tomorrow. sorry

@arcticicestudio
Copy link
Contributor

No problem, take your time and do not stress, my study time is also eating all my weekends 😐

@arcticicestudio
Copy link
Contributor

Superseded by #108

@arcticicestudio arcticicestudio added this to the 0.9.0 milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants