Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Invisible" DiffText #121

Merged
merged 2 commits into from
May 7, 2018
Merged

Bug: "Invisible" DiffText #121

merged 2 commits into from
May 7, 2018

Conversation

ironhouzi
Copy link
Contributor

Make single line diffs visible. The old colours was hiding these changes.

Make single line diffs visible. The old colours was hiding these changes.
@arcticicestudio
Copy link
Contributor

arcticicestudio commented May 5, 2018

🚀 Thanks for your contribution 👍

Can you please specify more why this change is necessary and maybe provide a screenshot and example code (e.g. .patch file to test with vimdiff / vim -d?
I currently don't know what's the exact problem with the current color and not able to reproduce it without more details.

Also, have you seen that there is a theme configuration for uniform diff background colors? Maybe it resolves your problem when you enable it with let g:nord_uniform_diff_background = 1.

@ironhouzi
Copy link
Contributor Author

Before:
nord-bug
After:
nord-fix

I prefer disabling g:nord_uniform_diff_background, so please verify that the changes for that setting looks good.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented May 5, 2018

Alright, I've been a bit confused about the "single line diffs" which I know as inline change marker 😄

This should definitely be changed, but I'd like to use one color from the Frost sub palette instead of nord14. The reason is that is might be a bit confusing if removed code is marked with a greenish color which actually marks added code.
I've tested it with nord9 which works well in my opinion.

gh-121-inline-diff-nord9-preview

@ironhouzi
Copy link
Contributor Author

Looks amazing! I was hoping you'd bring a nice aesthetic touch to the PR.

The reason is that is might be a bit confusing if removed code is
marked with a greenish color which actually marks added code.

GH-121
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed the change to use nord9. Also tested it with enabled g:nord_uniform_diff_background configuration and it works fine too.

Thanks again for the PR 👍

gh-121-inline-diff-nord9-uniform_diff_bg-preview

@arcticicestudio arcticicestudio merged commit 65c559e into nordtheme:develop May 7, 2018
@arcticicestudio arcticicestudio added this to the 0.9.0 milestone May 7, 2018
@ironhouzi ironhouzi deleted the pronounced_difftext branch May 7, 2018 11:53
@arcticicestudio
Copy link
Contributor

Changelog resources

Before (default diff mode)

After (uniform diff mode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants