Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for airline warning and error colors #130

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Add support for airline warning and error colors #130

merged 2 commits into from
Apr 15, 2019

Conversation

axelitus
Copy link
Contributor

I noticed there weren't colors defined for the errors and warnings of airline, so I've added those to the airline nord theme.

@axelitus
Copy link
Contributor Author

Without warninng color:
image

With warning color:
image

@arcticicestudio arcticicestudio self-requested a review June 28, 2018 04:17
@arcticicestudio arcticicestudio self-assigned this Apr 14, 2019
@arcticicestudio arcticicestudio added this to the 0.11.0 milestone Apr 14, 2019
arcticicestudio
arcticicestudio requested changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @axelitus 👋
Thanks for your contributions and patience 👍

I've been too busy with my "real" life and the development of the official Nord website to work on the massive amount of issues/PRs that were submitted each day for all of Nord's port projects.

Your changes looking good to me except that we should use nord1 instead of nord3 as foreground for warnings for better saturation and visual distinction to the background.
I've added the code change suggestions as comment to this PR.

Release Note Assets

Before

After

@axelitus
Copy link
Contributor Author

No worries, I know how too busy can feel overwhelming sometimes. I'll take a look at it later today or tomorrow.

@arcticicestudio arcticicestudio mentioned this pull request Apr 14, 2019
Open
axelitus added a commit to axelitus/nord-vim that referenced this pull request Apr 14, 2019
@axelitus
Add more contrast between background and text
b6dd55c 
As suggested in the comments of pull request nordtheme#130
@axelitus
Copy link
Contributor Author

Totally agreed with your comments. It's better with more contrast.

I have added a commit which implements your suggestions.

@arcticicestudio arcticicestudio force-pushed the feature/airline-warn-and-error-color branch from b6dd55c to 2a633e2 Compare April 15, 2019 20:12
@arcticicestudio
Copy link
Contributor

I've rebased your branch on top of the develop branch and resolved the merge conflict and will merge it to deploy it with the next release version 🚀
Thanks again for the PR 👍

@arcticicestudio arcticicestudio merged commit e85dbe7 into nordtheme:develop Apr 15, 2019
@axelitus axelitus deleted the feature/airline-warn-and-error-color branch April 16, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

@arcticicestudio arcticicestudio arcticicestudio approved these changes

Assignees
No one assigned
Labels
context-plugin context-ui scope-compatibility type-feature
Projects
None yet
Milestone
version-0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@axelitus @arcticicestudio @svengreb