changes of IncSearch color so that were difference from Search color #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcticicestudio
requested changes
Apr 13, 2019
There was a problem hiding this comment.
Hi @aborzunov 👋
Thanks for your contribution 👍
I think in addition to #41 this improves the visual distinction to the other highlighted elements, but I'd like to suggest to use nord10 as background and nord6 as foreground colors instead of nord13. It matches the theme ambience more while still achieving the same effect.
Co-Authored-By: aborzunov <[email protected]>
arcticicestudio
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
@aborzunov Thanks for the update, will merge it now to include it into the next release 👍
svengreb
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes IncSearch color so there were difference from standard Search color, fixes #139
