fixes high-contrast colors in diffs #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically, backgrounds for diff hl options are set to nord1, as the default colors are very high contrast
|
I know you commented already and may already have a solution, but I had never made a pull request (despite working with git for a while), so I was just trying my hand. Maybe it will be useful for you, but it's also a very simple fix. Here is a screenshot, as well:
thanks for the great colorscheme! I'm about to start using it a lot probably 😃 |
arcticicestudio
added a commit
to drzel/nord-vim
that referenced
this pull request
Sep 23, 2017
Revert back the included code changes of the PRs nordtheme#50 and nordtheme#53. nordthemeGH-48
|
Thanks for your contribution 👍 I've posted a suggestions in #49 to resolve this as new theme configuration. |
This was referenced Sep 28, 2017
Closed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49
basically, backgrounds for diff hl options are set to nord1, as
the default colors are very high contrast