-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature => Pre-commit hook #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be fantastic! I use pre-commit a lot and this is a perfect fit for it. |
norwoodj
requested changes
Aug 7, 2019
Hey @sc250024 thanks a ton for the submission! I had a few comments, wasn't entirely clear why the whole getopt implementation was necessary for the script, but otherwise this is fantastic. If you can fix the couple comments up, I will merge this |
norwoodj
reviewed
Aug 8, 2019
@norwoodj I updated based on the changes you requested. |
norwoodj
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables this repository to serve as source for a
helm-docs
pre-commit hook compatible with the Pre-commit project. Alternatively, this could be its own repository; something likepre-commit-helm-docs
.Huge shoutout to @antonbabenko and the https://github.com/antonbabenko/pre-commit-terraform project, where I took most of the code from.
Description
In a nutshell, this enables someone using
pre-commit
to do something like the following in their Helm charts repository:.pre-commit-config.yaml
If there are changes to their Helm chart (which are detected by
helm-docs
itself), this will automatically generate a correspondingREADME.md
file. If the user hadn't updated and staged theREADME.md
file before, this hook will fail, and ensure that a user always updates theirREADME.md
before they do a commit.Motivation and Context
I was always doing this manually before:
$ cd stable/some-chart $ helm-docs $ git add README.md
Since I make extensive use of the Pre-Commit project, I wanted a hook to automatically generate the
README.md
for a chart I just changed.How Has This Been Tested?
Tested locally. If you want to test a Helm chart repo against this hook, run the following in your Helm charts repo:
You should see that the hook will say "FAIL" because the
README.md
file changed, but it hasn't been staged yet. After staging, thepre-commit try-repo
command will succeed.Types of changes
Checklist: