[Bugfix] Parse on errorMatcher.set / handle no errorMatcher correctly #145
Conversation
|
I tried to rebase this and run the test but I can't get it to work. Do you have time to look into this? |
|
Done. |
| }; | ||
|
|
||
| ErrorMatcher.prototype._goto = function (id) { | ||
| var match = _.findWhere(this.currentMatch, { id: id }); | ||
| if (!match) { | ||
| throw new Error('Can\'t find match with id ' + id); | ||
| } |
There was a problem hiding this comment.
Doesn't seem like this can ever occur. In the _gotoNext function it is protected by a check for 0 === this.currentMatch.length, and in the matchFirst function it is checked that there actually is a first match.
(If I missed some case where it actually happens, it should emit the error rather than throwing).
There was a problem hiding this comment.
You're correct, that it schouldn't happen. It's more like defensive programming, if the other functions change in the future. But you are also correct, that it should emit an error.
[Bugfix] Parse on errorMatcher.set / handle no errorMatcher correctly
|
Thank you so much for this! Once again, sorry for taking so long to review this |
This PR fixes two bugs: