Improve default keybindings for Linux/Windows

[jhasse]

Currently the default key bindings on Linux and Windows aren't optimal. For example ctrl-alt-t is already used by most distros to open a terminal, see #163. In general it's uncommon for Linux apps to use ctrl-alt-* keybindings as they are usually used by system apps.

After looking through the issues, it looks to me that only people on Linux/Windows have problems with the default keybindings: #168, #198.

Also note that ctrl-alt-* has some problems on Windows, see this post which advises not to use them on Windows at all: atom/atom-keymap#35 (comment)

Last but not least they are rather uncommon among existing build apps like Sublime Text or CodeBlocks.

I've tried to find some new defaults, here is my reasoning for them:

• f4 error-match: This is the keybindings Sublime Text uses.
• shift-f4 error-match-first: Should be similar to error-match, therefore added shift.
• f9 trigger: This is used by CodeBlocks for build and run
• f7 select-active-target: To match Visual Studio's build shortcut. Maybe change to shift-f9?
• f8 toggle-panel: A key between f7 and f9 :D I'm not sure about this one.

Also see #168 (comment) for suggestions.

What do you think? :)

[noseglid]

Thanks for looking into this so thoroughly! I like your reasoning and I'd be happy to merge changes to the keybinding. However, I think we will be better off if we leave the old keybindings in place and just add the keybindings you're suggesting. I don't see any reason to restrict them to Windows/Linux either.

[jhasse]

You're right, that will result in fewer surprises when users update ;)
How can I add multiple keymaps?
Should all three be documented?

[noseglid]

You should add something like this to the keymaps.json

"atom-workspace, atom-text-editor": {
  "f9": "build:trigger",
  "f8": "build:toggle-panel",
  "f4": "build:error-match",
  "shift-f4": "build:error-match-first",
  "f7": "build:select-active-target"
}

in addition to what's already there.

I think it's sane to document them all.

[jhasse]

Done :)

In the text, I left the changes for recommending cmd-alt-* for OS X and the new keybindings for Linux/Windows. IIRC f keys are rarely used on Mac and always need the Fn key on Macbooks.

[noseglid]

Great. thanks!