Use regexps with '/g' modifier to replace all matches of built-in vars. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. Thanks! |
noseglid
added a commit
that referenced
this pull request
Nov 4, 2015
Use regexps with '/g' modifier to replace all matches of built-in vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand javascript's "replace" with string arguments does only single replacement. I needed to replace all matches when building some of the Go projects. The use case was to redefine an environment variable like so:
"GOPATH": "{PROJECT_PATH}:{PROJECT_PATH}/vendor". With this fix it actually works.