Skip to content

Commit

Permalink
crypto: remove deperecated methods of TLS version
Browse files Browse the repository at this point in the history
All version-specific methods were deprecated in OpenSSL 1.1.0 and
min/max versions explicitly need to be set.
This still keeps comptatible with JS and OpenSSL-1.0.2 APIs for now.

crypto, constants: add constant of OpenSSL-1.1.0

Several constants for OpenSSL-1.1.0 engine were removed and renamed in
OpenSSL-1.1.0. This added one renamed constant in order to have a
compatible feature with that of OpenSSL-1.0.2.
Other missed or new constants in OpenSSL-1.1.0 are not yet added.

crypto,tls,constants: remove OpenSSL1.0.2 support

This is semver-majar change so that we need not to have
compatibilities with older versions.

Fixes: nodejs/node#4270
PR-URL: nodejs/node#19794
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
shigeki committed Apr 9, 2018
1 parent 2b23583 commit 970ce14
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 218 deletions.
12 changes: 2 additions & 10 deletions src/node_constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -917,12 +917,8 @@ void DefineOpenSSLConstants(Local<Object> target) {
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_RAND);
# endif

# ifdef ENGINE_METHOD_ECDH
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_ECDH);
# endif

# ifdef ENGINE_METHOD_ECDSA
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_ECDSA);
# ifdef ENGINE_METHOD_EC
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_EC);
# endif

# ifdef ENGINE_METHOD_CIPHERS
Expand All @@ -933,10 +929,6 @@ void DefineOpenSSLConstants(Local<Object> target) {
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_DIGESTS);
# endif

# ifdef ENGINE_METHOD_STORE
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_STORE);
# endif

# ifdef ENGINE_METHOD_PKEY_METHS
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_PKEY_METHS);
# endif
Expand Down
Loading

0 comments on commit 970ce14

Please sign in to comment.