Changes reactions to not include the entire thread as e-tags. #1221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current guidance recommends including all
e
tags andp
tags, but no other tags, from the liked post in the reaction event. I believe this is a relic of the past and should be deprecated.There is no need to index the entire thread in every single reaction. The indexing burden in popular threads is real. I would argue reactions should only point to the note receiving the reaction and nothing else.
Reasons for the change:
e
tags for the entire thread. This means that some reactions include thee
tags for the entire thread while others only includeroot
andreply
, and others only include thereply
without the marker. Since we also havemention
andq
tags,mention
s are added to the reaction's tag array whileq
tags are not. Conclusion: there is no consistency for reaction counters that are not the reacted event.a
tags existed, soa
tags are not even included.