-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Zap splits to NIP-57 #552
Conversation
Love it. Aligned with all of these changes. I proposed something similar in the original zap-tag PR and also made it part of ZapGates I even think that the use of lud06 and 16 should be discouraged because it can lead to stale zap targets on non-replaceable events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been in the first PR
Can we not do integer percents? Percents are really weird because they're essentially for display. I'd strongly prefer a number from 0 to 1. |
Then we need to come up with rules for what happens when the amounts do not match 100%. The weight system is just a generalization of percentages to avoid worrying about mistakes in the client creating those weights. |
They are not percents, but weights. So you could do 1, 1, 2 which would mean 0.25, 0.25, 0.5 |
Interesting! Leave it as is then, that's a clean solution. Maybe explain that in the NIP. |
why do we need lud16,lud06? can't we just have pubkey so we don't have to handle N different UI variations for this? |
@vitorpamplona maybe using weights that add up to exactly 100 is not ideal, because some people might think that those actually are numbers in percent. If you make it 1,1,2 for example and explain that that equals 0.25,0.25,0.5 it gets much clearer |
I am in favor in killing lud16 and lud06 options. |
If we kill lud16 and lud06 options, do we want a relay address as 3rd parameter for consistency with other hex + relay tags or should we just move weights to the 3rd? Option 1:
Option 2
I think consistency is good. |
option 1 is fine |
yeah, I like option 1 too and I'm in favor of killing luds, which will make it easier to display the splits |
I'm in favor of option 1 as well |
What is the relay tag for |
A tip for where to get the author's metadata from |
Moved text to Option 1. |
Option 2 for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option 1
This would be one lnurl pay request per zap tag, right? Does this require mobile clients to have NWC to work practically? (otherwise a user would need to manually pay multiple invoices?) |
Yes, that is correct. NWC or any other QOL wallet connection like an integrated one, a connection to a node or Webln |
On Thu, May 25, 2023 at 03:28:35AM -0700, Egge wrote:
> This would be one lnurl pay request per zap tag, right? Does this require mobile clients to have NWC to work practically? (otherwise a user would need to manually pay multiple invoices?)
Yes, that is correct.
yes, lnurl prisms are insecure. it's better if clients know who they are zapping.
|
We should advocate with wallets to allow a uri scheme were we can send many invoices to be paid at the same time for those who don't want to use NWC. |
Regarding zap splits without NWC, I propose a simple solution (edit: github couldn't link to exact text: https://github.com/nostr-protocol/nips/blob/b9424fd454b124b5a61941d611f71336623cf582/96.md#monetization:~:text=If%20NIP%2D47%20isn%27t%20configured%2C). Taking advantage of the popularity of this thread, I ask client authors to review the related NIP-96 PR part (previous link) that talks about how file storage servers should get a share of the money on zap splits. |
I can't even add this to Damus, yet now I'm "out of spec" on my own spec. This should have been a different NIP. |
I see that it says "SHOULD", so I guess it's fine. |
Yeah, this looks very complicated. I would prefer that people don't do it, but. |
zap
tag in events from one to manyzap
tagging with pubkeyWhile using lud06 and lud16 removes the need to download a user's profile metadata, pubkeys make it safer for users to know if a given lightning address is in fact owned by the user they want to send to. Clients can display ln addresses, but it would be better to display a picture + the name of the receiving user before confirming the zap split.