Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify sort order when specified limit #674

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

AsaiToshiya
Copy link
Collaborator

From reading #579, #663 and the implementation of major relays, it seems that the descending order of the created_at is a common understanding, so this PR clarified it.

@Egge21M
Copy link
Contributor

Egge21M commented Jul 19, 2023

Just to make it really clear I would rephrase it further:

"When limit: n is present it is assumed that the events returned in the initial query will be the last n events ordered by created_at"

@AsaiToshiya
Copy link
Collaborator Author

Thanks for your feedback.

@fiatjaf fiatjaf merged commit b503f8a into nostr-protocol:master Jul 21, 2023
@AsaiToshiya AsaiToshiya deleted the patch-15 branch September 12, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants