Update to [email protected] #71
Conversation
|
Upon further testing I realize this is currently incomplete, and does not build, due to changes with the removal of I will attempt to make the appropriate fixes and update my PR shortly. |
|
See the migration guide for help: https://github.com/emilk/egui/blob/master/CHANGELOG.md#-migration |
As per emilk/egui#4524. Tested locally in `v0x0g/rayna`
|
@emilk Fixed and updated, everything seems to be working fine. I have just tested:
I bumped the version to |
| self.egui_input.events.push(event); | ||
| self.egui_input.events.push(egui::Event::MouseWheel { | ||
| modifiers, | ||
| unit: egui::MouseWheelUnit::Line, |
There was a problem hiding this comment.
Is this really the unit miniquad uses, always? Sadly it is not documented: https://docs.rs/miniquad/latest/src/miniquad/event.rs.html#170
Maybe @not-fl3 knows?
There was a problem hiding this comment.
Yes, I also noticed that it's not documented there.
I ended up doing some testing and adding dbg!(delta) inside the event handler, which ended up printing multiples of one every time I scrolled: [1.0, 0.0], [-1.0, 0.0], [0.0, 1.0] (every single event was +- 1.0). I tested using both my mouse and trackpad, and got a consistent [1.0, 0.0] for every 'click' of the scroll wheel, so I'm, fairly confident it's in lines.
There was a problem hiding this comment.
I don't :|
On most platforms its just a raw data from an OS message, on some its fixed 1.0/-1.0.
We do not normalize it in any way.
|
Published as 0.15.0 |
Follows https://github.com/emilk/egui/releases/tag/0.28.0