-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: align Notation with OCI specs #663
Conversation
…erimental Signed-off-by: patrick <[email protected]>
Signed-off-by: patrick <[email protected]>
Signed-off-by: patrick <[email protected]>
Signed-off-by: patrick <[email protected]>
Signed-off-by: patrick <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 33.33% 36.28% +2.95%
==========================================
Files 32 32
Lines 2019 1973 -46
==========================================
+ Hits 673 716 +43
+ Misses 1324 1229 -95
- Partials 22 28 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: patrick <[email protected]>
Signed-off-by: patrick <[email protected]>
Signed-off-by: patrick <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Patrick Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR:
sign
,list
,inspect
, andverify
commands. When a user wants to try the Referrers API, they need to set bothNOTATION_EXPERIMENTAL=1
AND--allow-referrers-api
; if the Referrers API is not supported, fallback to the Referrers tag schema automatically. Otherwise, by default, Notation would use the Referrers tag schema in all commands deterministically.References:
https://github.com/opencontainers/distribution-spec/blob/v1.1.0-rc1/spec.md#listing-referrers
https://github.com/opencontainers/distribution-spec/blob/v1.1.0-rc1/spec.md#referrers-tag-schema
This PR has been tested and:
resolves #659
resolves #660