Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump up versions and dependencies #670

Merged
merged 2 commits into from
May 17, 2023

Conversation

priteshbandi
Copy link
Contributor

bump up versions and dependencies for rc5

@Two-Hearts
Copy link
Contributor

@priteshbandi looks like the build is failed.

@shizhMSFT
Copy link
Contributor

You may want to merge #656 and #658 first

@codecov-commenter
Copy link

Codecov Report

Merging #670 (a68d326) into main (3d78a89) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   36.12%   36.12%           
=======================================
  Files          32       32           
  Lines        1982     1982           
=======================================
  Hits          716      716           
  Misses       1238     1238           
  Partials       28       28           
Impacted Files Coverage Δ
internal/version/version.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou mentioned this pull request May 17, 2023
4 tasks
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Member

We reached the majority of approval. @gokarnm @rgnote Could you pls merge this PR?

@priteshbandi priteshbandi merged commit d850c3f into notaryproject:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants