update: renamed flag --plain-http to --insecure-registry #674
Conversation
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
patrickzheng200,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 61.37% 61.35% -0.02%
==========================================
Files 42 42
Lines 2281 2280 -1
==========================================
- Hits 1400 1399 -1
Misses 782 782
Partials 99 99 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
changed the title
Signed-off-by: Patrick Zheng <[email protected]>
There was a problem hiding this comment.
@yizha1 @Two-Hearts Should we just drop --plain-http in RC versions?
RC-5 is the last RC release. The next is v1 release. |
Then we should drop the |
cmd/notation/common.go
Outdated
| opts.Username = os.Getenv(defaultUsernameEnv) | ||
| opts.Password = os.Getenv(defaultPasswordEnv) | ||
| } | ||
|
|
||
| func aliasNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedName { |
There was a problem hiding this comment.
Recommend removing aliasing to avoid breaking post RC to GA. Also this should be used only for test either way.
There was a problem hiding this comment.
Recommend removing aliasing to avoid breaking post RC to GA. Also this should be used only for test either way.
Got it. Updated the code to remove aliasing.
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
changed the title
Thanks @shizhMSFT, good point! I updated the code to reflect it. |
|
Agree to drop |
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This PR is based on discussions in issue #623 with following changes:
--plain-httpto--insecure-registryfor notationsign,verify,list,inspectandlogin.And added the original flag name--plain-httpas an alias of the new name.use HTTP protocol while connecting to registries. Should be used only for testing. Related specs are updated as well.Resolves #623.